QUALITY

[zhiva]

http://forums.wowace.com/showpost.php?p=309123

Errors in Blizzard(!!!) code in patch 4.0.1:

FrameXML/BNet.lua:333 missing local declaration for "givenName" in BNet_InitiateReport
FrameXML/BNet.lua:333 missing local declaration for "surname" in BNet_InitiateReport
FrameXML/BuffFrame.lua:300 missing local declaration for "index" in BuffFrame_UpdateAllBuffAnchors
FrameXML/ChatFrame.lua:1863 missing local declaration for "name" in *function:1853-1880*
FrameXML/ChatFrame.lua:1863 missing local declaration for "rank" in *function:1853-1880*
FrameXML/ContainerFrame.lua:680 GLOBAL "_" is set in ContainerFrame_GetExtendedPriceString
FrameXML/FriendsFrame.lua:647 GLOBAL "days" is set in PendingList_Scroll
FrameXML/FriendsFrame.lua:647 missing local declaration for "timeSent" in PendingList_Scroll
FrameXML/FriendsFrame.lua:647 missing local declaration for "givenName" in PendingList_Scroll
FrameXML/FriendsFrame.lua:647 missing local declaration for "inviteID" in PendingList_Scroll
FrameXML/FriendsFrame.lua:1274 missing local declaration for "button" in FriendsFrame_UpdateFriends
FrameXML/FriendsFrame.lua:1275 missing local declaration for "index" in FriendsFrame_UpdateFriends
FrameXML/LootFrame.lua:112 missing local declaration for "questTexture" in LootFrame_UpdateButton
FrameXML/MailFrame.lua:92 GLOBAL "itemSubType" is set in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 GLOBAL "itemType" is set in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 missing local declaration for "itemTexture" in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 missing local declaration for "itemName" in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 GLOBAL "itemEquipLoc" is set in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 GLOBAL "itemStackCount" is set in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 GLOBAL "itemMinLevel" is set in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 GLOBAL "itemLevel" is set in MailFrame_OnEvent
FrameXML/MailFrame.lua:92 missing local declaration for "itemRarity" in MailFrame_OnEvent
FrameXML/MerchantFrame.lua:467 missing local declaration for "currencyName" in MerchantFrame_ConfirmExtendedItemCost
FrameXML/MovieFrame.lua:18 GLOBAL "volume" is set in MovieFrame_PlayMovie
FrameXML/PaperDollFrame.lua:504 GLOBAL "_" is set in PaperDollFrame_SetLevel
FrameXML/PaperDollFrame.lua:3513 GLOBAL "_" is set in RecalculateGearManagerDialogPopup
FrameXML/PaperDollFrame.lua:3597 GLOBAL "_" is set in GearManagerDialogPopup_Update
FrameXML/PVPFrame.lua:309 GLOBAL "_" is set in PVPFrame_UpdateCurrency
FrameXML/PVPFrame.lua:387 GLOBAL "_" is set in PVPFrame_TabClicked
FrameXML/PVPFrame.lua:475 GLOBAL "_" is set in PVPHonor_UpdateBattlegrounds
FrameXML/PVPFrame.lua:807 GLOBAL "_" is set in PVPConquestFrame_Update
FrameXML/PVPFrame.lua:807 missing local declaration for "ratedArenaReward" in PVPConquestFrame_Update
FrameXML/PVPFrame.lua:1000 missing local declaration for "played" in PVPTeamManagementFrame_UpdateTeamInfo
FrameXML/PVPFrame.lua:1001 missing local declaration for "wins" in PVPTeamManagementFrame_UpdateTeamInfo
FrameXML/PVPFrame.lua:1012 missing local declaration for "loss" in PVPTeamManagementFrame_UpdateTeamInfo
FrameXML/PVPFrame.lua:1046 missing local declaration for "button" in PVPTeamManagementFrame_UpdateTeamInfo
FrameXML/PVPFrame.lua:1069 missing local declaration for "seasonLoss" in PVPTeamManagementFrame_UpdateTeamInfo
FrameXML/PVPFrame.lua:1087 missing local declaration for "winLossText" in PVPTeamManagementFrame_UpdateTeamInfo
FrameXML/PVPFrame.lua:1186 GLOBAL "_" is set in PVPTeamManagementFrame_UpdateTeams
FrameXML/QuestInfo.lua:61 missing local declaration for "bottomShownFrame" in QuestInfo_Display
FrameXML/QuestInfo.lua:198 GLOBAL "_" is set in QuestInfo_DoReputations
FrameXML/QuestInfo.lua:198 missing local declaration for "hasRep" in QuestInfo_DoReputations
FrameXML/QuestInfo.lua:287 GLOBAL "_" is set in QuestInfo_ShowObjectivesText
FrameXML/SpellBookFrame.lua:1012 missing local declaration for "offset" in SpellBookCompanionButton_OnClick
FrameXML/StaticPopup.lua:3142 missing local declaration for "moneyInputFrame" in StaticPopup_Show
FrameXML/UIDropDownMenu.lua:500 missing local declaration for "uncheckImage" in UIDropDownMenu_Refresh
FrameXML/UIDropDownMenu.lua:937 missing local declaration for "uncheckImage" in UIDropDownMenu_ClearAll
FrameXML/UIParent.lua:3667 missing local declaration for "xCoord" in SetGuildTabardTextures
FrameXML/UIParent.lua:3668 missing local declaration for "yCoord" in SetGuildTabardTextures
FrameXML/WatchFrame.lua:893 missing local declaration for "objectiveType" in WatchFrame_DisplayTrackedQuests
FrameXML/WorldMapFrame.lua:2008 missing local declaration for "questFrame" in WorldMapQuestFrame_UpdateMouseOver
FrameXML/WorldMapFrame.lua:2062 GLOBAL "_" is set in WorldMapQuestPOI_SetTooltip
FrameXML/WorldStateFrame.lua:843 GLOBAL "_" is set in WorldStateScoreFrame_Update

AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 GLOBAL "firstComletionTime" is set in ArchaeologyFrame_UpdateComplete
AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 missing local declaration for "description" in ArchaeologyFrame_UpdateComplete
AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 GLOBAL "_" is set in ArchaeologyFrame_UpdateComplete
AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:329 missing local declaration for "spellDescription" in ArchaeologyFrame_UpdateComplete
AddOns/Blizzard_GuildUI/Blizzard_GuildUI.lua:163 GLOBAL "_" is set in GuildFrame_LinkItem
AddOns/Blizzard_InspectUI/InspectPaperDollFrame.lua:32 GLOBAL "_" is set in InspectPaperDollFrame_SetLevel
AddOns/Blizzard_TalentUI/Blizzard_TalentUI.lua:1454 missing local declaration for "tab" in PlayerTalentFrame_UpdateTabs
AddOns/Blizzard_TokenUI/Blizzard_TokenUI.lua:177 missing local declaration for "itemID" in BackpackTokenFrame_Update
AddOns/Blizzard_TradeSkillUI/Blizzard_TradeSkillUI.lua:171 missing local declaration for "numSkillUps" in TradeSkillFrame_Update
AddOns/Blizzard_TradeSkillUI/Blizzard_TradeSkillUI.lua:181 missing local declaration for "skillButtonNumSkillUps" in TradeSkillFrame_Update
AddOns/Blizzard_TradeSkillUI/Blizzard_TradeSkillUI.lua:182 missing local declaration for "skillButtonNumSkillUpsIcon" in TradeSkillFrame_Update
AddOns/Blizzard_TrainerUI/Blizzard_TrainerUI.lua:191 missing local declaration for "hasReq" in ClassTrainerFrame_SetServiceButton